Skip to content

fix(tke): [120885420] tencentcloud_kubernetes_node_pool add new params #2979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

SevenEarth
Copy link
Collaborator

No description provided.

@SevenEarth SevenEarth changed the title fix(tke): tencentcloud_kubernetes_node_pool add new params fix(tke): [120885420] tencentcloud_kubernetes_node_pool add new params Nov 28, 2024
@hellertang hellertang merged commit 2e09358 into master Nov 29, 2024
8 checks passed
@hellertang hellertang deleted the fix/tke_node_tip branch November 29, 2024 06:49
"wait_node_ready": {
Type: schema.TypeBool,
Optional: true,
Description: "Whether to wait for all expansion resources to be ready. Default is false. Only can be set if `enable_auto_scale` is `false`.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是节点:all desired nodes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -6,6 +6,8 @@ Provide a resource to create an auto scaling group for kubernetes cluster.

~> **NOTE:** In order to ensure the integrity of customer data, if the cvm instance was destroyed due to shrinking, it will keep the cbs associate with cvm by default. If you want to destroy together, please set `delete_with_instance` to `true`.

~> **NOTE:** There are two parameters `wait_node_ready` and `scale_tolerance` to ensure better management of node pool scaling operations. If this parameter is set, when creating resources, if the set criteria are not met, the resources will be marked as `tainted`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉这句话不太通顺?If this parameter is set, when creating resources, if the set criteria are not met,

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -143,6 +145,72 @@ resource "tencentcloud_kubernetes_node_pool" "example" {
}
```

Set `wait_node_ready` and `scale_tolerance`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for all scaling nodes to be ready with wait_node_ready and scale_tolerance parameters.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants